Cut v1.11.0 #877
Merged
Cut v1.11.0 #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
|
cc @lilic |
|
Thank you! 馃帀 |
beorn7
reviewed
Jun 7, 2021
There was a problem hiding this comment.
Looks good.
Just my nits, feel free to ignore or take into account for the future as you see fit:
- So far, the lines end with periods.
- We usually put changes first, then features, then enhancements, then bugfixes.
- Not sure if I would call the new collectors package a change. But then it includes a deprecation, so it might be best to call it out as a change.
Thinking about the last point: Best might be to call out the new dbstats collector as a feature, and mention that it is in a new collectors package. And then call out the deprecation as a change in a separate entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Fixes #876
cc @beorn7 Could you have look at it in case I've missed anything? It's my first release 馃槄