Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.11.0 #876

Closed
howardjohn opened this issue Jun 3, 2021 · 2 comments · Fixed by #877
Closed

Release v1.11.0 #876

howardjohn opened this issue Jun 3, 2021 · 2 comments · Fixed by #877
Assignees

Comments

@howardjohn
Copy link

Since the changes to drop github.com/go-kit/kit have been merged, it would be great to tag a new release to encourage downstream importers to pick up the new version. Without doing this, the change is not effective since all dependencies need to be updated to now import the large dependency to have any impact.

See prometheus/common#255 for context.

Note: the PR to drop the dependency is already merged, I was just hoping to tag the release as tagged releases are much more likely to be adopted.

@kakkoyun kakkoyun self-assigned this Jun 4, 2021
@kakkoyun
Copy link
Member

kakkoyun commented Jun 4, 2021

@howardjohn Thanks for reaching out. I'm going to prioritise this and try to release it ASAP.

@sagikazarmark
Copy link

The circular dependency between client_golang and common is a bit unfortunate: in order to truly clean up the transitive dependency mess, client_golang neeeds to be released, common updated and released, then client_golang updated and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants