Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add start/end parameter for LabelNames #767

Merged
merged 2 commits into from Jun 11, 2020
Merged

add start/end parameter for LabelNames #767

merged 2 commits into from Jun 11, 2020

Conversation

Nexucis
Copy link
Member

@Nexucis Nexucis commented Jun 11, 2020

fixes #766

@Nexucis
add start/end parameter for LabelNames
6ce5f2c 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@beorn7 beorn7 requested a review from bwplotka June 11, 2020 13:08
@beorn7
Copy link
Member

beorn7 commented Jun 11, 2020

No worries about the go-1-10 CI failure, that's #765 .

bwplotka
bwplotka approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, LGTM 👍

Can we add start + name to LabelValues while we are here?

@beorn7
Copy link
Member

beorn7 commented Jun 11, 2020

Thanks, everyone.

@Nexucis would you like to add start + name to LabelValues as suggested by @bwplotka ? I'll leave this PR open for a while in case you just want to add a commit here.

(And once this is in, it's time for a new release.)

@Nexucis
Copy link
Member Author

Nexucis commented Jun 11, 2020

Ah yes np I will modify the LabelValues as well

@Nexucis Nexucis requested a review from bwplotka June 11, 2020 13:47
@Nexucis
Copy link
Member Author

Nexucis commented Jun 11, 2020

here we go, parameter added to LabelValues :)

@beorn7
Copy link
Member

beorn7 commented Jun 11, 2020

Thanks, but now we have a genuine test failure.

@Nexucis
Copy link
Member Author

Nexucis commented Jun 11, 2020

:O, I'm a genius lol. Sorry about that. It seems I was bit too fast on it. Will fix it

@Nexucis
add start/end parameter for LabelValues
3defbd9 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the feature/labelNames-parameter branch from 3783289 to 3defbd9 Compare June 11, 2020 14:05
@Nexucis
Copy link
Member Author

Nexucis commented Jun 11, 2020 •
edited

Looks better now @beorn7 , sorry for the mess. I mixed up the query parameter and the path parameter

beorn7
beorn7 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everyone.

@beorn7 beorn7 merged commit c304bb0 into prometheus:master Jun 11, 2020
@Nexucis Nexucis deleted the feature/labelNames-parameter branch June 11, 2020 14:56
@slrtbtfs slrtbtfs mentioned this pull request Jun 17, 2020
Closed
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beorn7 beorn7 beorn7 approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1/api.go/LabelNames missing start/end time parameter
3 participants
@Nexucis @beorn7 @bwplotka