Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut v1.5.0 #720

Merged
merged 1 commit into from Mar 3, 2020
Merged

Cut v1.5.0 #720

merged 1 commit into from Mar 3, 2020

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Mar 3, 2020

Also @gotjosh , who did the API change.

@beorn7 beorn7 requested a review from bwplotka March 3, 2020 14:12
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

We already use promauto.With().New... in Thanos and it's amazing. We are even planning to block old prometheus.New... invokes in CI 🤗 Same thing Cortex (cc @pracucci) is considering so thanks for this 👍

CHANGELOG.md Outdated
@@ -1,3 +1,9 @@
## 1.5.0 / 2020-03-03

* [FEATURE] promauto: Add a factory to allow autoregistration with a local registry. #713
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [FEATURE] promauto: Add a factory to allow autoregistration with a local registry. #713
* [FEATURE] promauto: Add a factory to allow auto registration with a local registry. #713

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the doc comment, we use auto-register once, but the proper way is "automatic registration", which I'll do now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being picky ^^ I learned from the best.... (((:

Signed-off-by: beorn7 <beorn@grafana.com>
@bwplotka bwplotka merged commit 5538bed into master Mar 3, 2020
@bwplotka
Copy link
Member

bwplotka commented Mar 3, 2020

👍

@beorn7 beorn7 deleted the beorn7/release branch March 3, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants