Synchronize Makefile.common from prometheus/prometheus #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prombot <prometheus-team@googlegroups.com>
|
Thanks @simonpasquier . In general, as the maintainer of the repo, I'd like to have a say before something is merged, unless it is super urgent. Even if it looks like a trivial change, there might be a weirdness in a particular repo that will lead to problems in subtle ways. |
|
@beorn7 sorry for stepping on your toes. This change was only affecting projects using Circle CI while client_golang is still using Travis. |
|
That would be wonderful. Any help would be much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagating changes from master Makefile.common located in prometheus/prometheus.