Make use of pre-existing context in InstrumentRoundTripperTrace #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, seems ok to me. |
|
Thanks. Having tests for this is great. However, we don't want to pull in a dependency just for assertion. If you don't mind, I will just incorporate the essence of your tests into this PR. |
beorn7
force-pushed
the
beorn7/promhttp
branch
2 times, most recently
from
dee343d
to
56d3658
Compare
Fixes #580 Signed-off-by: beorn7 <bjoern@rabenste.in>
|
I think I got it all nicely packaged up. |
|
Incidentally, this also fixes the 1st flaky test mentioned in #573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
@shturec does this do the trick?