Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix client trace examples to actually capture metrics #535

Merged
merged 1 commit into from Feb 4, 2019
Merged

fix client trace examples to actually capture metrics #535

merged 1 commit into from Feb 4, 2019

Conversation

kklipsch
Copy link

@kklipsch kklipsch commented Feb 4, 2019

Signed-off-by: Kasey Klipsch junk@klipsch.net

fix client trace examples to actually capture metrics
a11607d 
Signed-off-by: kklipsch <kklipsch@example.com>
beorn7
beorn7 approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

(Now I'm wondering why the test doesn't verify that observations are actually happening. But that's another story. Same as calling out to an external web site. That has created flakiness of this test before…)

@beorn7 beorn7 merged commit 7190de1 into prometheus:master Feb 4, 2019
s-urbaniak added a commit to s-urbaniak/client_golang that referenced this pull request Mar 6, 2019
@s-urbaniak
prometheus/promhttp: actually observe values in trace in example
60728f4 
This is similar to
prometheus#535 fixing ExampleInstrumentRoundTripperDuration.

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
@s-urbaniak s-urbaniak mentioned this pull request Mar 6, 2019
Merged
Cori1109 added a commit to Cori1109/client_golang that referenced this pull request Jan 9, 2023
@Cori1109
prometheus/promhttp: actually observe values in trace in example
34a5a4d 
This is similar to
prometheus/client_golang#535 fixing ExampleInstrumentRoundTripperDuration.

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beorn7 beorn7 beorn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kklipsch @beorn7