Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock-free summaries without objectives #521

Merged
merged 2 commits into from
Jan 5, 2019
Merged

Lock-free summaries without objectives #521

merged 2 commits into from
Jan 5, 2019

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Dec 24, 2018

THis is similar to #457 .
Fixes #496 .

beorn7 added 2 commits December 24, 2018 11:22
Signed-off-by: beorn7 <beorn@soundcloud.com>
Signed-off-by: beorn7 <beorn@soundcloud.com>
@beorn7 beorn7 changed the title Lock-froo summaries without objectives Lock-free summaries without objectives Dec 24, 2018
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for all the comments (again)!

@beorn7
Copy link
Member Author

beorn7 commented Jan 5, 2019

Yeah, it's just copied and slightly adjusted. But I thought that's clearer than trying to DRY at all cost.

@beorn7 beorn7 merged commit cf7da0f into master Jan 5, 2019
@beorn7 beorn7 deleted the beorn7/summary branch January 5, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants