Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI]: Add Concurrency Grouping to GitHub Workflows #1437

Closed
Ishani217 opened this issue Jan 26, 2024 · 2 comments · Fixed by #1444
Closed

[CI]: Add Concurrency Grouping to GitHub Workflows #1437

Ishani217 opened this issue Jan 26, 2024 · 2 comments · Fixed by #1444

Comments

@Ishani217
Copy link
Contributor

Requirement

Whenever we push commits to a PR, workflows are triggered for that commit. After that, if we push additional commits to this PR, workflows in Github Actions run on both commit

Problem

We need to cancel the previous run and run only on the most recent pushed commit. This would help save some GitHub Action Minutes and unexpected workflow failures on subsequent commits.

Proposal

Use concurrency groups to achieve this
@Ishani217
Copy link
Contributor Author

@ArthurSens @kakkoyun Could you please give me a heads up on this issue. I would love to solve this, to gain experience with this project.

@ArthurSens
Copy link
Member

Hi @Ishani217, we haven't had any issues with Action minutes as far as I can remember

I don't see a reason to not do this though, so feel free to come up with a PR :)

@Ishani217 Ishani217 mentioned this issue Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI]: Add Concurrency Grouping to GitHub Workflows Ishani217/client_golang
2 participants
@ArthurSens @Ishani217