Fix go_collector_latest_test Fail on go1.19 #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rogerogers <rogers@rogerogers.com>
rogerogers
force-pushed
the
feature/test
branch
from
c9c9479
to
322ccbd
Compare
|
When this is merged, it would be nice to also update the circleci config to actually test with Go 1.19 (as the release notes state). |
When the latest minor release was published, Go 1.19 wasn't officially released, thus the metrics are not the latest file and the CI hasn't added Go 1.19 stage. We will add the support with the upcoming release. |
kakkoyun
reviewed
Nov 7, 2022
|
ref: #1160 |
|
I decided to merge this and base the other PR on these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix go_collector_latest_test Fail on go1.19
#1135
Signed-off-by: rogerogers rogers@rogerogers.com