Make Query requests idempotent #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address prometheus#1020. Signed-off-by: Tomáš Dohnálek <dohnto@gmail.com>
dohnto
commented
Apr 7, 2022
Signed-off-by: Tomáš Dohnálek <dohnto@gmail.com>
dohnto
force-pushed
the
dohnto/post-idempotent
branch
from
a1b532e
to
7016fd3
Compare
kakkoyun
reviewed
Apr 12, 2022
| @@ -1138,6 +1138,9 @@ func (h *apiClientImpl) DoGetFallback(ctx context.Context, u *url.URL, args url. | |||
| return nil, nil, nil, err | |||
| } | |||
| req.Header.Set("Content-Type", "application/x-www-form-urlencoded") | |||
| // Underlying `net.http` library automatically retries` idempotent requests when connectivity issues are hit. | |||
| // POST requests are not considered idempotent by default, so we need to explicitly mark them as such. | |||
| req.Header["Idempotency-Key"] = nil | |||
There was a problem hiding this comment.
Could you please at the docs directly here?
Transport only retries a request upon encountering a network error if the request is idempotent and either has no body or has its Request.GetBody defined. HTTP requests are considered idempotent if they have HTTP methods GET, HEAD, OPTIONS, or TRACE; or if their Header map contains an "Idempotency-Key" or "X-Idempotency-Key" entry. If the idempotency key value is a zero-length slice, the request is treated as idempotent but the header is not sent on the wire.
And a link to the docs?
There was a problem hiding this comment.
PTAL.
I think we should squash before merging. Not sure if I am suppose to do that, or the Github's UI is used for it?
dohnto
force-pushed
the
dohnto/post-idempotent
branch
from
66ac0ad
to
ebe4b5b
Compare
Signed-off-by: Tomáš Dohnálek <dohnto@gmail.com>
dohnto
force-pushed
the
dohnto/post-idempotent
branch
from
ebe4b5b
to
5588f73
Compare
kakkoyun
approved these changes
Apr 13, 2022
|
@dohnto Amazing work. Thanks for taking care of it. |
|
Looking forward to having this change in a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1020.
Signed-off-by: Tomáš Dohnálek dohnto@gmail.com
This was challenging to test. I used toxiproxy to inject connectivity issues. I build a custom Toxic which counts HTTP requests a closes every even request.
Without the header set, the conversation was following and my range query ended with
When I set the idempotency header, the conversation was equal to the case when GET is used - the connection is reopen and the request is retried.