pkg/prometheus/promcfg*.go: Validate EnforcedBodySizeLimit

[slashpai]

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Added the input validation for EnforcedBodySizeLimit

Related to #4282

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Added the input validation for EnforcedBodySizeLimit

cc: @simonpasquier

[simonpasquier]

I think that the operator should be more explicit and fail the reconciliation if the provided parameter is invalid.

[slashpai]

I think that the operator should be more explicit and fail the reconciliation if the provided parameter is invalid.

I propagated the error from validation that should fail sync

[slashpai]

@fpetkovski @simonpasquier Can you review again?

[fpetkovski]

Nice work, this LGMT!

[simonpasquier]

IMHO the check should happen near the top of *ConfigGenerator.GenerateConfig() since it's a PrometheusSpec field?

prometheus-operator/pkg/prometheus/promcfg.go

Line 219 in c6b5cc2

func (cg *ConfigGenerator) GenerateConfig(

[slashpai]

IMHO the check should happen near the top of *ConfigGenerator.GenerateConfig() since it's a PrometheusSpec field?

prometheus-operator/pkg/prometheus/promcfg.go

Line 219 in c6b5cc2

func (cg *ConfigGenerator) GenerateConfig(

Good point. I added a func for validating the fields at prometheus crd level. Added the func call in operator.go before calling GenerateConfig

@simonpasquier Can you take a look?

[simonpasquier]

Can you base your change against release-0.51 so it can be part of v0.51.2?

[slashpai]

@simonpasquier I updated with changed and changed the base for PR

[slashpai]

@simonpasquier I updated with changed and changed the base for PR
just realized I didn't update error string, updating soon

[slashpai]

Done

[slashpai]

@simonpasquier Take a look when you get chance

[slashpai]

@simonpasquier Thank you for the review. I updated the PR. Hope its good now :)

[simonpasquier]

lgtm

[simonpasquier]

thanks!

[slashpai]

@simonpasquier Curious to know would this change be synced with master only before release of 0.51.2?

[simonpasquier]

@slashpai yes this is the process.