Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-pages automatically generated on every master push #6

Open
celian-garcia opened this issue May 1, 2020 · 6 comments
Open

gh-pages automatically generated on every master push #6

celian-garcia opened this issue May 1, 2020 · 6 comments

Comments

@celian-garcia
Copy link
Contributor

celian-garcia commented May 1, 2020

Roughly, the idea is to add a job/pipeline in circle ci with this command flow :

npm install
npm run build
npm link
cd examples/angular-promql
npm install
npm link monaco-promql
npm install -g angular-cli-ghpages
npm run build -- --prod --base-href "https://prometheus-community.github.io/monaco-promql/"
ngh -d dist/angular-promql

So that the gh-pages would contains the latest code of monaco-promql. Not necessarily the released one but the master one.

@celian-garcia
Copy link
Contributor Author

Necessit PR #4 to be merged to make the linking work

@Nexucis
Copy link
Contributor

Nexucis commented May 2, 2020

Not necessary a good idea because gh-pages is the way to expose your project and will be the way for people to use it.

So if for any reason it's not stable, you will loose some people.
I don't think using it as a "integration test" is the good way to use it.

@celian-garcia
Copy link
Contributor Author

The idea here was just to automatize the generation of the gh-pages.

If you don't like to generate it from master we can then generate on tags I honestly don't really care and see any difference.

That said we need to find a way to control the display yes with kind of integration tests. Too bad you disagree because gh-pages was an easy way to achieve it... Maybe we can deploy several stuff in gh-pages...

@celian-garcia
Copy link
Contributor Author

Yeah it's possible with subfolders, we can have :

  • under root ("/") : the latest deployed version, using a vanilla example
  • under angular ("/angular") : the latest deployed version, using angular as client
  • under react ("/react") : the latest deployed version, using react as client
  • under master ("/master") : one or several examples using master as source for the lib

It is possible using what is described in this gist https://gist.github.com/cobyism/4730490

@celian-garcia
Copy link
Contributor Author

We can even use single-spa framework to have every example in the same webpage (angular + react + vanilla) it is possible.

@Nexucis
Copy link
Contributor

Nexucis commented May 3, 2020

The idea to automatize is interesting. I would prefere to do it through a tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants