Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Convert to using Slider UserParam class #1340

Merged
merged 1 commit into from
May 25, 2022

Conversation

rht
Copy link
Contributor

@rht rht commented May 24, 2022

Not yet finished. Depends on #1331 to be merged.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1340 (0b75cbc) into main (1825534) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          19       19           
  Lines        1323     1323           
  Branches      255      255           
=======================================
  Hits         1201     1201           
  Misses         86       86           
  Partials       36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1825534...0b75cbc. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature.
@rht rht force-pushed the userparam_slider branch from 20eb8c4 to 0b75cbc Compare May 24, 2022 10:34
@rht rht marked this pull request as ready for review May 24, 2022 10:34
@rht
Copy link
Contributor Author

rht commented May 24, 2022

Ready for review.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @rht!!

LGTM

@tpike3 tpike3 merged commit 8000dfb into projectmesa:main May 25, 2022
@rht rht deleted the userparam_slider branch May 25, 2022 10:12
@jackiekazil jackiekazil added this to the Quartzsite (next release) milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants