Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Builder/SuperBuilder setterPrefix configurable from lombok.config #3159

Closed
mickroll opened this issue Mar 31, 2022 · 1 comment
Closed

Comments

@mickroll
Copy link

As there is the @Builder(setterPrefix = "...") option, it would make sense to have the ability of setting it once across the project at the lombok.config.
An example would be using lombok.builder.setterPrefix = set to have a project-wide prefix set for bean-like builder access.
For consistency, the config value should be used as default value by @SuperBuilder as well, just like lombok.builder.className is used by @SuperBuilder already.

Justification:

  • Improved signal-to-noise ratio
  • Better readability (arguably)
  • Helps keeping project convention consistent

BTW this feature request somewhat follows #2849, to have a project wide consistent config for (very) often used lombok features.

@rzwitserloot
Copy link
Collaborator

We won't do this. The reason we offered it in the first place is if you're making a builder that needs to fit specific needs, e.g. because it has to implement an interface or you're using it with some backwards library that expects silly defaults.

Specifically, with (the common prefix) is, in our opinion, highly misleading. There's no point in having a lombok.config setting other than 'I want to apply it everywhere regardless of circumstance' and we're not (currently) seeing the point of that. Builder is in its infancy, relatively speaking. 'there are many ways to do it' engenders pointless style quibbles and needlessly increases learning curves.

We like the java community and wouldn't want to make it worse by introducing pointless customization options like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants