Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Lombok Maven+ECJ bootstrap agent #3143

Closed
jopatai opened this issue Mar 17, 2022 · 2 comments
Closed

[FEATURE] Lombok Maven+ECJ bootstrap agent #3143

jopatai opened this issue Mar 17, 2022 · 2 comments

Comments

@jopatai
Copy link
Contributor

jopatai commented Mar 17, 2022

I have created (but not published) a small bootstrap agent to make using Lombok with Maven and the ECJ compiler easier. That combination currently requires either a non-portable build (as described on the setup/ecj page) or putting lombok.jar into source control with your project. The bootstrap agent allows you to contain the build in your pom.xml without embedding lombok.jar.

The project is located at https://github.com/JohnPaulTaylorII/lombok-maven-ecj-bootstrap.

Questions:

  1. Is this worth including in the projectlombok space rather than mine? (I know it's fairly niche.)
  2. If not, is it okay to publish this artifact using the org.projectlombok group, or would you prefer if I use a different one?
  3. Would a PR updating the setup/ecj page to explain this alternative setup be accepted?

Thanks for your consideration.

@rzwitserloot
Copy link
Collaborator

I don't mind either the jar file directly in the projectlombok git repo or this solution; but how do we efficiently 'get it' there? We could fold it into lombok.jar and ask users to e.g. run java -jar lombok.jar setupMavenBootstrapper which unpacks this tiny jar and makes that .mvn/jvm.config file as well. Perhaps it even adds/fixes your pom.xml file. That sounds slightly nicer, perhaps?

@jopatai
Copy link
Contributor Author

jopatai commented Mar 17, 2022

I hadn't been able to come up with a very good distribution technique... However, that does sound like a pretty good solution. I can certainly work on that integration.

rzwitserloot added a commit that referenced this issue Apr 2, 2022
* Update copyright headers
* Update code style (tabs, not spaces, spaces around + operator - that's about it)
* Use `x.class.getResourceAsStream`, not `x.getClass().` - minor mostly irrelevant nit.
* Rename and re-locate the jar itself.
* 'ecj' as an alias for this command seems a bit too cavalier' removed it.
* The source is in its own 'root' src dir, it doesn't really fit in the eclipse agent sources - it's more a maven agent.
* Fixed a bug where a filehandle wasn't safe closed. Mostly irrelevant (JVM would quite afterwards anyway).
* Slight rewording of the ecj docs.
rzwitserloot added a commit that referenced this issue Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants