Add syntax highlighting and javadoc to language server (VSCode) #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2950
For the syntax highlighting I added the language server
SemanticTokensVisitorto hide generated lombok nodes. I also renamed the patch method because it now handles more things than only refactorings.To fix the javadoc I added patches for the language server copy of
JavadocContentAccess2, they modified it to also support markdown. I also had to add some reflection code to callCompilationUnit::originalFromClonebecause the language server implementation uses a working copy for compilation and the original compilation unit to resolve the comments.