Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset inference context for extension methods #2658

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

Rawi01
Copy link
Collaborator

@Rawi01 Rawi01 commented Nov 25, 2020

This PR fixes #2648.

In Java >= 8 ecj uses the inference context to resolve the generic information. This one is already set before lombok tries rewrite the method call. Simply copying the information does not cover all the different cases but reseting the inference contexts and running type inference again does.

…formation copy

In Java >= 8 ecj uses the inference context to resolve the generic
information. This one is already set before lombok tries rewrite the
method call. Simply copying the information does not cover all the
different cases but reseting the inference contexts and running type
inference again does.
@rzwitserloot
Copy link
Collaborator

Ooh, that's a much better way to solve this problem than me writing tons of code to try to reproduce all the various TypeBinding objects. This feels like one of those 'saves you an entire coding week's worth of effort' PRs. All PRs are very welcome but some PRs are very welcome indeed.

Feels significant enough for a changelog entry, I'll add a commit in a bit for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ExtensionMethod for generic types does not work with generic parameters in ecj
2 participants