Skip to content

[BUG] Delombok removes explicit this #2444

Closed
@mkondratek

Description

@mkondratek

Describe the bug
Delombok removes explicit this

To Reproduce
Having a class with methods that contain explicit this, like:
public void updateUI(@UnknownInitialization GitMacheteGraphTable this)
delombok generates code without the explicit this

Expected behavior
Explicit this kept after delombok

Version info (please complete the following information):

  • Lombok from gradle pluginio.freefair.lombok version 5.0.0
  • gradle version 6.3
  • Intellij 2020.1

Additional context
origin issue: freefair/gradle-plugins#217

Activity

rspilker

rspilker commented on May 7, 2020

@rspilker
Collaborator

Thanks for reporting this. We did recently look into this (no pun intended) when generating code to support the checker framework.

I can reproduce the problem.

Rawi01

Rawi01 commented on May 7, 2020

@Rawi01
Collaborator

@rspilker I just fixed this one and can provide a pull request if you haven't already fixed it too.

rspilker

rspilker commented on May 7, 2020

@rspilker
Collaborator

It was a problem in the pretty printer. We did not print the recvparam field. It was introduced in java8.

rspilker

rspilker commented on May 7, 2020

@rspilker
Collaborator

I did fix it and added tests.

rspilker

rspilker commented on May 7, 2020

@rspilker
Collaborator

@Rawi01 Thanks for the offer.

Rawi01

Rawi01 commented on May 7, 2020

@Rawi01
Collaborator

It's fascinating that we managed to fix the same issue at the same time with exactly the same changes 😂

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rspilker@Rawi01@mkondratek

        Issue actions

          [BUG] Delombok removes explicit this · Issue #2444 · projectlombok/lombok