Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated go mod and adjusted stringsutil recent changes #68

Merged

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Aug 2, 2022

closes #67

@LuitelSamikshya LuitelSamikshya self-assigned this Aug 2, 2022
@LuitelSamikshya LuitelSamikshya added bug Something isn't working Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Aug 2, 2022
hostsfile/hostsfile.go Outdated Show resolved Hide resolved
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Follow up ticket at #69 related to increase test coverage

@ehsandeep ehsandeep merged commit e2b34ab into master Aug 4, 2022
@ehsandeep ehsandeep deleted the issue-67-error-installing-because-of-changed-stringutil branch August 4, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Review Needed The issue has a PR attached to it which needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error installing because of a changed stringutil
3 participants