Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalIPs checker #43

Merged
merged 2 commits into from Jan 27, 2022
Merged

InternalIPs checker #43

merged 2 commits into from Jan 27, 2022

Conversation

ehsandeep
Copy link
Member

@ehsandeep ehsandeep commented Jan 27, 2022 •
edited by Mzack9999

This PR adds two new fields to the JSON data result:

  • has_internal_ips: true if at least one A/AAAA record points to RFC local ips
  • internal_ips: slice containing ipv4/ipv6 internal ips (if any)

Mzack9999
Mzack9999 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mzack9999 Mzack9999 added the enhancement New feature or request label Jan 27, 2022
@ehsandeep ehsandeep merged commit 97378f2 into master Jan 27, 2022
@ehsandeep ehsandeep deleted the internal-checker branch January 27, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehsandeep @Mzack9999 @Ice3man543