Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stop method #20

Merged
merged 4 commits into from Dec 22, 2022
Merged

Add Stop method #20

merged 4 commits into from Dec 22, 2022

Conversation

Mzack9999
Copy link
Member

Closes #19

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 22, 2022
@Mzack9999 Mzack9999 self-assigned this Dec 22, 2022
@Mzack9999 Mzack9999 mentioned this pull request Dec 22, 2022
Merged
4 tasks
tarunKoyalwar
tarunKoyalwar reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mzack9999 , I think we would also need to expose this in multiLimiter

@Mzack9999 Mzack9999 merged commit aa416f1 into main Dec 22, 2022
@Mzack9999 Mzack9999 deleted the bugfix-go-routine-leak branch December 22, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

context.CancelFunc go routine leaks
2 participants
@Mzack9999 @tarunKoyalwar