Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlsx integration issue with scan all ips option #2920

Closed
ehsandeep opened this issue Nov 28, 2022 · 1 comment · Fixed by #2950
Closed

tlsx integration issue with scan all ips option #2920

ehsandeep opened this issue Nov 28, 2022 · 1 comment · Fixed by #2950
Assignees
Labels
Investigation Something to Investigate Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone

Comments

@ehsandeep
Copy link
Member

ehsandeep commented Nov 28, 2022

Nuclei version:

master/dev

Above function is triggered in nuclei at

}
response, err := request.tlsx.Connect(host, host, port)
if err != nil {

i.e

response, err := request.tlsx.Connect(host, host, port)

instead of passing ip if scanallIps is enabled nuclei always passes hostname to tlsx . when connecting using hostname only one of the ip is selected .

Originally posted by @tarunKoyalwar in projectdiscovery/tlsx#112 (comment)

Anything else?

#2709

@ehsandeep ehsandeep added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Investigation Something to Investigate labels Nov 28, 2022
@ehsandeep
Copy link
Member Author

once this is confirmed, we can also close projectdiscovery/tlsx#112

@ehsandeep ehsandeep added this to the v2.8.0 milestone Nov 28, 2022
@Mzack9999 Mzack9999 linked a pull request Dec 2, 2022 that will close this issue
4 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigation Something to Investigate Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants