Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-exclude-ports Flag Fails to Function Correctly When Used Alongside -passive Flag #998

Closed
abd-4fg opened this issue Mar 17, 2024 · 2 comments · Fixed by #1004
Closed

-exclude-ports Flag Fails to Function Correctly When Used Alongside -passive Flag #998

abd-4fg opened this issue Mar 17, 2024 · 2 comments · Fixed by #1004
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone

Comments

@abd-4fg
Copy link

abd-4fg commented Mar 17, 2024

The -exclude-ports is not working properly , i have kept these two ports as exluded :
naabu -l domains.txt -exclude-ports 80,443 -o output.txt
However , still i am getting domains with :443 or :80 in the output file.

Naabu version:

2.3.0

@abd-4fg abd-4fg added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 17, 2024
@dogancanbakir dogancanbakir self-assigned this Mar 18, 2024
@dogancanbakir
Copy link
Member

dogancanbakir commented Mar 18, 2024

Thanks for opening this issue. I couldn't repro the issue:

with exclude-ports

$ go run . -host hackerone.com -top-ports 1000 -exclude-ports 80,443

                  __
  ___  ___  ___ _/ /  __ __
 / _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/

                projectdiscovery.io

[INF] Current naabu version 2.3.0 (latest)
[INF] Running CONNECT scan with non root privileges
hackerone.com:8443
hackerone.com:8080
[INF] Found 2 ports on host hackerone.com (172.64.151.42)

without exclude-ports:

$ go run . -host hackerone.com -top-ports 1000                      

                  __
  ___  ___  ___ _/ /  __ __
 / _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/

                projectdiscovery.io

[INF] Current naabu version 2.3.0 (latest)
[INF] Running CONNECT scan with non root privileges
hackerone.com:443
hackerone.com:8443
hackerone.com:8080
hackerone.com:80
[INF] Found 4 ports on host hackerone.com (104.18.36.214)

Do you mind sharing your repro steps, including hosts? Over Discord, maybe?

@abd-4fg
Copy link
Author

abd-4fg commented Mar 18, 2024

Hi ,
I guess i found the cause of this problem i have :
It looks like when having -passive (grepping open ports from shodan) flag in command , it ignores -exclude-ports
image

Is this intentional or bug ?

@dogancanbakir dogancanbakir changed the title -exclude-ports flag is not working as intended. -exclude-ports Flag Fails to Function Correctly When Used Alongside -passive Flag Mar 18, 2024
@dogancanbakir dogancanbakir changed the title -exclude-ports Flag Fails to Function Correctly When Used Alongside -passive Flag -exclude-ports Flag Fails to Function Correctly When Used Alongside -passive Flag Mar 18, 2024
@dogancanbakir dogancanbakir linked a pull request Mar 18, 2024 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Mar 23, 2024
@ehsandeep ehsandeep added this to the naabu v2.3.1 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants