Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Controller Runtime Reconcile Tests #3705

Closed
danehans opened this issue May 24, 2021 · 0 comments · Fixed by #3773
Closed

Add Controller Runtime Reconcile Tests #3705

danehans opened this issue May 24, 2021 · 0 comments · Fixed by #3773
Assignees
@danehans
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
Contour Project Board
Milestone
1.17.0

Comments

@danehans
Copy link
Contributor

Please describe the problem you have
#3510 added controller-runtime controllers but no tests for these controllers. Tests should be added to test controller functionality.
@danehans danehans added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 24, 2021
@danehans danehans added this to Unprioritized in Contour Project Board via automation May 24, 2021
@danehans danehans mentioned this issue May 24, 2021
Merged
@stevesloka stevesloka assigned danehans and unassigned stevesloka Jun 7, 2021
@danehans danehans mentioned this issue Jun 9, 2021
Merged
@danehans danehans moved this from Unprioritized to 1.17 release in Contour Project Board Jun 14, 2021
@danehans danehans added this to the 1.17.0 milestone Jun 14, 2021
@danehans danehans mentioned this issue Jun 20, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danehans danehans

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
No open projects
Contour Project Board
  
1.17 release (completed)
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

Adds Controller Runtime Test Suite danehans/contour
2 participants
@stevesloka @danehans