Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test zot against s3 storage #210

Closed
andaaron opened this issue Jul 14, 2021 · 5 comments
Closed

test zot against s3 storage #210

andaaron opened this issue Jul 14, 2021 · 5 comments
Assignees
Labels
Projects

Comments

@andaaron
Copy link
Contributor

andaaron commented Jul 14, 2021

Theoretically zot should work with S3 storage if we:

In order to test this integration

In the production version of this feature, the S3 configuration parameters as well as the zot configuration would be passed to the zot container using kubernetes specific objects.

@andaaron andaaron created this issue from a note in zot-core (In progress) Jul 14, 2021
@rchincha
Copy link
Contributor

Issue #206
Issue #179

@rchincha rchincha changed the title Test zot against S3 storage test zot against s3 storage Jul 14, 2021
@rchincha rchincha added ci/cd feature New feature or request performance and removed feature New feature or request performance labels Jul 14, 2021
@peusebiu
Copy link
Collaborator

peusebiu commented Jul 15, 2021

Small test on my machine using TestParallelRequests Suite:

normal one:

--- PASS: TestParallelRequests (0.18s)
    --- PASS: TestParallelRequests/Request-4 (9.14s)
    --- PASS: TestParallelRequests/Request-2 (12.48s)
    --- PASS: TestParallelRequests/Request-6 (12.89s)
    --- PASS: TestParallelRequests/Request-12 (12.97s)
    --- PASS: TestParallelRequests/Request-8 (13.04s)
    --- PASS: TestParallelRequests/Request-3 (13.70s)
    --- PASS: TestParallelRequests/Request-1 (16.81s)
    --- PASS: TestParallelRequests/Request-5 (17.36s)
    --- PASS: TestParallelRequests/Request-10 (10.42s)
    --- PASS: TestParallelRequests/Request-14 (9.63s)
    --- PASS: TestParallelRequests/Request-11 (13.62s)
    --- PASS: TestParallelRequests/Request-9 (13.41s)
    --- PASS: TestParallelRequests/Request-13 (12.69s)
    --- PASS: TestParallelRequests/Request-7 (13.55s)
PASS
ok      github.com/anuvu/zot/pkg/api    26.668s

s3fuse + minio:

--- PASS: TestParallelRequests (0.29s)
    --- PASS: TestParallelRequests/Request-4 (39.80s)
    --- PASS: TestParallelRequests/Request-3 (76.65s)
    --- PASS: TestParallelRequests/Request-6 (78.74s)
    --- PASS: TestParallelRequests/Request-8 (78.74s)
    --- PASS: TestParallelRequests/Request-2 (79.31s)
    --- PASS: TestParallelRequests/Request-12 (79.31s)
    --- PASS: TestParallelRequests/Request-1 (152.00s)
    --- PASS: TestParallelRequests/Request-10 (75.82s)
    --- PASS: TestParallelRequests/Request-14 (74.84s)
    --- PASS: TestParallelRequests/Request-7 (157.56s)
    --- PASS: TestParallelRequests/Request-13 (84.86s)
    --- PASS: TestParallelRequests/Request-5 (143.05s)
    --- PASS: TestParallelRequests/Request-9 (105.13s)
    --- PASS: TestParallelRequests/Request-11 (106.02s)
PASS
ok      github.com/anuvu/zot/pkg/api    185.089s

@rchincha
Copy link
Contributor

rchincha commented Jul 15, 2021

Maybe benchmarks also? https://pkg.go.dev/testing#hdr-Benchmarks
Hard to tell what the latency, etc is.
Wouldn't mind if that is part of #202 instead of this issue.

@rchincha
Copy link
Contributor

One good argument against using fuse mounts is that perhaps under some circumstances such as deploying containers, privileges to mount are not available/allowed. In which case, we may have to directly interact with the s3 APIs.

@rchincha rchincha moved this from In progress to Review pending in zot-core Oct 20, 2021
@peusebiu
Copy link
Collaborator

closed in 9c568c0

zot-core automation moved this from Review pending to Done Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
zot-core
  
Done
Development

No branches or pull requests

3 participants