Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: Add support for multiple test suites with separate local validators #1681

Merged
merged 22 commits into from Mar 30, 2022
Merged

lang: Add support for multiple test suites with separate local validators #1681

merged 22 commits into from Mar 30, 2022

Conversation

paul-schaaf
Copy link
Contributor

No description provided.

@paul-schaaf paul-schaaf force-pushed the multiple-test-suites-with-configs branch from fb1416f to d8a6d06 Compare March 25, 2022 01:37
@paul-schaaf
Copy link
Contributor Author

@armaniferrante this is ready for review but a test in the CI is falling and I havent found the reason yet. Im not able to reproduce it locally. if it fails on your machine that might give us a lead

@paul-schaaf
Copy link
Contributor Author

logging the ledger logs in the ci helped. we have to update to Solana 1.9 to get access to the --account flag in the ci

@paul-schaaf
Copy link
Contributor Author

blocked by #1653

@paul-schaaf paul-schaaf marked this pull request as ready for review March 27, 2022 16:54
tomlinton
tomlinton reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@tomlinton tomlinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it worked great. Some minor nits would be renaming forth-suite to fourth-suite and consistent casing on the ts filenames. No impact on the functionality tough.

armaniferrante
armaniferrante approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@armaniferrante armaniferrante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits. ship it.

tests/multiple-suites/tests/fourth-and-fifth-suite/fifth-suite/fifthSuite.ts Outdated Show resolved Hide resolved
cli/src/config.rs Show resolved Hide resolved
cli/src/config.rs Outdated Show resolved Hide resolved
cli/src/config.rs Show resolved Hide resolved
@paul-schaaf paul-schaaf merged commit 470e902 into coral-xyz:master Mar 30, 2022
@paul-schaaf paul-schaaf mentioned this pull request Apr 1, 2022
Closed
This was referenced Apr 11, 2022
Closed
Closed
polarisiota
polarisiota reviewed Apr 13, 2022
View reviewed changes
Copy link

@polarisiota polarisiota left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlinton tomlinton tomlinton left review comments

@polarisiota polarisiota polarisiota left review comments

@armaniferrante armaniferrante armaniferrante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paul-schaaf @tomlinton @armaniferrante @polarisiota