Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl: re-export the spl_token::AuthorityType enum #1665

Merged
merged 4 commits into from Mar 23, 2022
Merged

spl: re-export the spl_token::AuthorityType enum #1665

merged 4 commits into from Mar 23, 2022

Conversation

callensm
Copy link
Member

No description provided.

@fanatid
Copy link
Contributor

fanatid commented Mar 22, 2022

Maybe re-export whole spl_token crate?

@callensm
Copy link
Member Author

Most of what of core functionality of spl_token is covered by the wrapping functions/structs in anchor_spl. The only thing (personally) that I've ever been annoyed by is constantly having to depend on spl_token as well solely for the AuthorityType enum.

If there are other things in spl_token that need re-exporting as well, would probably be best to do them individually as to not expose the core functions that anchor_spl wraps.

@paul-schaaf
Copy link
Contributor

If there are other things in spl_token that need re-exporting as well, would probably be best to do them individually as to not expose the core functions that anchor_spl wraps.

is this a problem though? If you're using anchor_spl, you're not gonna use those functions and this way we don't have to update the re-exports

@callensm
Copy link
Member Author

no its not a problem, if that's what you want to do I can update the PR to re-export all of spl_token.

@paul-schaaf
Copy link
Contributor

ok yea re-export it all then

@paul-schaaf paul-schaaf merged commit 4e4ca55 into coral-xyz:master Mar 23, 2022
@paul-schaaf
Copy link
Contributor

thanks!

@callensm callensm deleted the spl/authority-type branch March 23, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants