spl: change "to" to "from" in token::burn #1080
Conversation
|
Can you add a changelog entry in a |
inso-
force-pushed
the
master
branch
2 times, most recently
from
6df6e6a
to
658d314
Compare
inso-
changed the title
inso-
force-pushed
the
master
branch
2 times, most recently
from
09cc6b9
to
44c129d
Compare
fix makefile
|
I fixed the makefile, now it should pass the tests also 🙏 @armaniferrante can you link the issue #161 to the PR? |
| @@ -3,47 +3,56 @@ build-cli: | |||
| cargo build -p anchor-cli --release | |||
| cp target/release/anchor cli/npm-package/anchor | |||
|
|
|||
| .PHONY: build-tests-bpf-% | |||
There was a problem hiding this comment.
Why are makefile changes needed? Seems like they shouldn't be.
There was a problem hiding this comment.
On the current makefile rules build-example-bpf-all do not work because basic-0 to basic-4 are not located on "examples/" but in "examples/tutorial" (and basic-5 do not exist anymore)
Also all other examples are not located on "examples/" but on "tests/".
Since tests and tutorial is now split in two different folder I separate them in 2 different rule: "build-tests-bpf-all" and "build-example-bpf-all".
I added the rule "build-all" to build tests and tutorials.
|
hey @inso- are you interested in finishing this? if yes, pls undo the makefile changes. We have a separate issue for that |
|
closed by #1729 |
This is quite confusing and a suggestion to change this already have been approved.
#161