Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Rework the bootstrapper, add CoreOS etcd support #55

Open
karalabe opened this issue Oct 22, 2014 · 4 comments
Open

Rework the bootstrapper, add CoreOS etcd support #55

karalabe opened this issue Oct 22, 2014 · 4 comments

Comments

@karalabe
Copy link
Member

The bootstrapper is one of the oldest components of the system and should really be rewritten. As part of that effort, I'd also like to add seamless coreos/etcd integration to take advantage of its discovery service if available. Although this is not really a necessity per se, but it's fairly simple to do and could make converging on CoreOS clusters extremely fast.

For details, please see the below discussions:

@coopernurse
Copy link

Excellent!

@karalabe
Copy link
Member Author

I've reworked mostly the bootstrapper. It should theoretically take into accound local etcd instances to use as seed servers. Couple issues currently:

  • Rate limiting is missing. I've yet to include a proper one. Currently one IP is probed/100ms. I'd like to replace this mechanism with a token bucket + an additional rate control from the upper layer pastry. This will probably be done in two phases, but enough to say that currently the bootstrapper is not working as intended until a proper rate limiter is in place.
  • There is a bug in the pastry implementation if the bootstrap rate is too high. Tests begin failing if I probe 1IP/10ms (probably the same IPs get found multiple times and there's some race condition or something similar). This should also be sorted out before this issue can be closed or next version released.

@karalabe karalabe added bug and removed bug labels Oct 23, 2014
@coopernurse
Copy link

Great, does this require any user configuration, or does it look for etcd on localhost:4001?

I wonder if we need to make this etcd endpoint configurable. With CoreOS/Docker I believe we'd want to connect to etcd running on the CoreOS host.

@karalabe
Copy link
Member Author

Localhost 7001 (and the newly allocated IANA port), both IPv4 and 6. I don't think a configuration is warranted. I see no reason for people to override the etcd ports, especially if running stock CoreOS on cloud machines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants