Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Disallow sending empty messages #48

Open
karalabe opened this issue Sep 12, 2014 · 1 comment
Open

Disallow sending empty messages #48

karalabe opened this issue Sep 12, 2014 · 1 comment
Labels

Comments

@karalabe
Copy link
Member

It should be decided whether empty messages make sense or not, but if not, they should be explicitly disallowed and violating connections dropped to prevent faulty API uses.

The current relay protocol spec cannot accept empty tunnel messages, so either a rework is needed there, or just disable empty messages everywhere.

@karalabe
Copy link
Member Author

After sleeping on this a bit, I think I'm going to disallow empty messages. This approach is backward compatible in the sense that it should not require a heavy relay protocol redesign rewrite. It may break code using empty messages, but imho that was already broken by design, so lets correct this here and now and not propagate invalid/ambiguous use of the system.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant