Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0071: Potential segfault in the time crate #398

Closed
github-actions bot opened this issue Oct 18, 2021 · 7 comments
Closed

RUSTSEC-2020-0071: Potential segfault in the time crate #398

github-actions bot opened this issue Oct 18, 2021 · 7 comments
Assignees
Labels

Comments

@github-actions
Copy link
Contributor

Potential segfault in the time crate

Details
Package time
Version 0.1.44
URL time-rs/time#293
Date 2020-11-18
Patched versions >=0.2.23
Unaffected versions =0.2.0,=0.2.1,=0.2.2,=0.2.3,=0.2.4,=0.2.5,=0.2.6

Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

The affected functions from time 0.2.7 through 0.2.22 are:

  • time::UtcOffset::local_offset_at
  • time::UtcOffset::try_local_offset_at
  • time::UtcOffset::current_local_offset
  • time::UtcOffset::try_current_local_offset
  • time::OffsetDateTime::now_local
  • time::OffsetDateTime::try_now_local

The affected functions in time 0.1 (all versions) are:

  • at
  • at_utc

Non-Unix targets (including Windows and wasm) are unaffected.

Patches

Pending a proper fix, the internal method that determines the local offset has been modified to always return None on the affected operating systems. This has the effect of returning an Err on the try_* methods and UTC on the non-try_* methods.

Users and library authors with time in their dependency tree should perform cargo update, which will pull in the updated, unaffected code.

Users of time 0.1 do not have a patch and should upgrade to an unaffected version: time 0.2.23 or greater or the 0.3. series.

Workarounds

No workarounds are known.

References

time-rs/time#293

See advisory page for additional details.

@kate-goldenring
Copy link
Contributor

kate-goldenring commented Oct 27, 2021

Looks like we are pulling in time v0.1.44 from chrono from kube-rs, k8s-openapi and opcua-client. Looks like chrono may be using an unaffected version of time anyway as stated in this issue: kube-rs/kube#650 (comment).
Issue to track: kube-rs/kube#650

@kate-goldenring
Copy link
Contributor

chrono PR to track: chronotope/chrono#578

@kate-goldenring kate-goldenring added this to Triage needed in Akri Roadmap Nov 2, 2021
@bfjelds bfjelds moved this from Triage needed to Investigating in Akri Roadmap Nov 2, 2021
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 1, 2022

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions github-actions bot added the stale label Feb 1, 2022
@github-actions github-actions bot closed this as completed May 2, 2022
Akri Roadmap automation moved this from Investigating to Done May 2, 2022
@kate-goldenring
Copy link
Contributor

ran cargo audit locally and this vulnerability still exists. Looks like kube-rs still has not resolved it kube-rs/kube#650

Akri Roadmap automation moved this from Done to Triage needed May 2, 2022
@kate-goldenring kate-goldenring moved this from Triage needed to Investigating in Akri Roadmap May 3, 2022
@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 1, 2022

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions github-actions bot added the stale label Aug 1, 2022
Akri Roadmap automation moved this from Investigating to Done Oct 31, 2022
Akri Roadmap automation moved this from Done to Triage needed Oct 31, 2022
@josephknierman josephknierman moved this from Triage needed to Investigating in Akri Roadmap Nov 1, 2022
@github-actions
Copy link
Contributor Author

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions
Copy link
Contributor Author

github-actions bot commented May 8, 2023

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions github-actions bot added the stale label May 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2023
Akri Roadmap automation moved this from Investigating to Done Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant