Addition to #230, added support for array coords #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpcboekema
force-pushed
the
coord-zm-value
branch
from
36ee618
to
2edff67
Compare
|
we probably want to generalize this for any array longer then 2 |
lib/core.js
Outdated
| else { | ||
| return [transformedArray.x, transformedArray.y]; | ||
| } | ||
| return [transformedArray.x, transformedArray.y].concat(coords.splice(2)); |
There was a problem hiding this comment.
why don't you put this where return [transformedArray.x, transformedArray.y, transformedArray.z]; with the conditional being coords.length > 2 that way the most common case isn't slowed down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #245 as fix for #230 is not working for all cases.
This fix also adds a solution when using an array as coords (with z or z and m value).