Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: fgprof - new sampling profiler for golang #96

Open
Slach opened this issue Jun 25, 2020 · 1 comment
Open

FYI: fgprof - new sampling profiler for golang #96

Slach opened this issue Jun 25, 2020 · 1 comment

Comments

@Slach
Copy link

Slach commented Jun 25, 2020

https://github.com/felixge/fgprof

@narqo
Copy link
Member

narqo commented Jun 25, 2020

fgprof produces the same pprof-formatted data as the Go's embedded profiler. profefe should support that out of the box. You might need to specify type=other when sending the profiles to the collector. Let me know if you can test that.

I don't think adding fgprof to the agent is a good idea (at least, not yet). As its author had mentioned in the thread, there are still some issues with the implementation but there are also chances it could be moved to the upstream in future versions of Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants