Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return labels as part of the profile list #50

Open
gianarb opened this issue Dec 9, 2019 · 1 comment
Open

return labels as part of the profile list #50

gianarb opened this issue Dec 9, 2019 · 1 comment

Comments

@gianarb
Copy link
Contributor

gianarb commented Dec 9, 2019

I use labels a lot and it will be nice to see them when selected the right profiles to merge (when I do a list in practice) in this way I can keep filtering until I get only the one I am looking for.

@narqo
Copy link
Member

narqo commented Dec 9, 2019

Could you show an example of what it's missing?

At least storage/badger returns the labels accociated with a profile with profiles list response:

$ curl -v 'http://localhost:10100/api/0/profiles?service=server&type=cpu&from=2019-03-13T09:00:00&to=2019-06-01T10:00:00' | jq .

{
  "code": 200,
  "body": [
    {
      "id": "bnnbo57budgsv59m02ag",
      "type": "cpu",
      "service": "server",
      "labels": [
        {
          "key": "dc",
          "value": "ams"
        },
        {
          "key": "host",
          "value": "ams-backend-1"
        }
      ],
      "created_at": "2019-03-13T10:49:58.0228644+01:00"
    },
    {
      "id": "bnnbna7budgsv59m02a0",
      "type": "cpu",
      "service": "server",
      "labels": [
        {
          "key": "dc",
          "value": "fra"
        },
        {
          "key": "host",
          "value": "backend-1"
        }
      ],
      "created_at": "2019-03-13T10:48:25.053972837+01:00"
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants