Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to trim paths in pprof file before importing it #12

Open
narqo opened this issue Mar 20, 2019 · 1 comment
Open

Allow to trim paths in pprof file before importing it #12

narqo opened this issue Mar 20, 2019 · 1 comment
Labels
question Further information is requested

Comments

@narqo
Copy link
Member

narqo commented Mar 20, 2019

Ref google/pprof#366

When we import a bunch of pprof files, we want to specify locations' common prefix, that must be trimmed before files were processed by the collector. This will reduce the amount of data stored in (the current implementation of postgres) storage.

This will require parsing pprof file before sending it to the collector, so it's likely that importer will have to be rewritten from a bash script to Go.

@narqo narqo changed the title Allow to trim paths from pprof file before importing it Allow to trim paths in pprof file before importing it Mar 20, 2019
@narqo
Copy link
Member Author

narqo commented Jun 26, 2019

Go 1.13 adds -trimpath build flag to

[..] remove all file system paths from the compiled executable, to improve build reproducibility.

See https://tip.golang.org/doc/go1.13#go-command

@narqo narqo added the question Further information is requested label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

1 participant