Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink profiling types #114

Open
narqo opened this issue Oct 11, 2020 · 0 comments
Open

Rethink profiling types #114

narqo opened this issue Oct 11, 2020 · 0 comments
Labels
question Further information is requested

Comments

@narqo
Copy link
Member

narqo commented Oct 11, 2020

Profiling types, profefe-collector accepts with the API requests is a predefined list. That made sense in the earlier versions, when profefe stored different profile types in the dedicated Postgres tables, with different schemas per type.

Currently, all types (expect "trace") are treated equally in all implementations of Storage.

Because the list is predefined, using profefe with languages, that expose different types, seems confusing. For example, the profiler for Node.js provides profiling data for "Wall time" and "Heap". It's not clear for a user, what profiling type they should use when sending the profiles to profefe-collector ("CPU time" shows CPU usage but "Wall time" shows total time). A general suggestion always was to use "other" when in doubt but there could be a better way to handle that.

A possible solution to explore is to suggest annotating the profiles with a "special" label, indicating the actual type of the profile. That is

/api/profiles?service=myapp&type=other&labels=lang=nodejs,profile_type=wall_time
@narqo narqo added the question Further information is requested label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

1 participant