Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/badger: Apply limit to results after sorting by created_at + type #106

Open
narqo opened this issue Sep 11, 2020 · 0 comments
Open

Comments

@narqo
Copy link
Member

narqo commented Sep 11, 2020

Following #99

Needs testing

As a user I expect a search query for ALL profile types to return a mixed set of profiles from the time period, ordered by created_at and type. But it seems that if limit parameter is passed, storage sorts the results by type first and cuts the "tail" of the results. E.g. if we store more cpu profiles in the results than the passed limit, and I requested for ALL profiles, I won't get any heap profiles.

An example query:

/api/0/profiles?service=refresh_worker&type=cpu&labels=dc%3Desh&from=2020-06-01T00%3A00%3A00&to=2020-09-11T06%3A21%3A00&limit=600

Note, there might be the same issue with storage/s3. storage/clickhouse works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant