Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CloudFormation tests optional and skip CFN finalizations when PR is unrelated to CloudFormation changes #909

Open
cmfcruz opened this issue Feb 27, 2024 · 0 comments

Comments

@cmfcruz
Copy link
Contributor

cmfcruz commented Feb 27, 2024

Running CloudFormation tests for PR unrelated to CloudFormation may block PR merges if the infrastructure has drifted and causes a CloudFormation test to fail. My suggestion is to make the CloudFormation tests optional if none of the changed files are related to CloudFormation. Likewise, finalization should skip CloudFormation actions if the merged PR has nothing to do with CloudFormation.

Aside from saving compute cycles, skipping CloudFormation tests or finalizations may avoid unexpected infrastructure changes caused by drifts. Rectification of drifts can cause outages as resources are modified or restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant