Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid matching node and npm versions defaults to node 16 #527

Open
otaviojacobi opened this issue Feb 23, 2023 · 1 comment
Open

Invalid matching node and npm versions defaults to node 16 #527

otaviojacobi opened this issue Feb 23, 2023 · 1 comment

Comments

@otaviojacobi
Copy link
Contributor

If you run a npm repo where node and npm versions do not match, such as:

...
 "engines": {
    "node": "^18.12.0",
    "npm": "^8.19.2"
  }
...

Rather than throwing an error, flowzone actually defaults to node 16 which makes understanding why your CI/CD broke harder.

@klutchell
Copy link
Collaborator

I think we could resolve this by making at least one engines check a requirement, with no fallback. We would have to update some repos that do not currently specify engine versions and have been getting by with the default v16.

Better yet, we could use the highest available node version matching the engine requirements and skip the rest. I don't recall why we didn't do that in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants