fix(receive): --base-url option and GHE_HOST
#1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes probot/probot/1333
Fixes probot/probot/probot#1333
|
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
gr2m
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Code changes look good! I'll merge it in as is.
What do you think about mentioning the new option in docs/simulating-webhooks.md? Feel free to send a follow up PR
gr2m
changed the title
--base-url option and GHE_HOST
|
Thanks for your contribution to probot! 🎉 |
|
🎉 This PR is included in version 12.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing probots on a self-hosted enterprise github instance, the command
probot receive -e push -p test/test-push.json ./index.jsdoes not recognize the GHE_HOST present in the .env file and does not allow the baseUrl to be modified in the receive arguments.This change allows the GHE_HOST value in the .env file to be recognized and also allows the host to be modified in the arguments of the command. Basically a copy and paste from read-cli-options.ts.
fixes #1556
fixes #1333