Please provide context as part of the onError callback

[trammel]

Feature Request

When setting an error handler, it'd be very useful to know the context and payload that caused the issue. This can then be logged, along with the error.

import { Probot } from "probot";
import { WebhookEventHandlerError } from "@octokit/webhooks/dist-types/types";

export = (app: Probot) => {
    app.onError(async (error: WebhookEventHandlerError) => {
        app.log(error);
        // app.log(context.payload)
    });
};

I believe this used to be possible, when using the creating webhooks named "*" and "error", but those were deprecated in favour of #1480

[welcome]

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

[AaronDewes]

https://github.com/octokit/webhooks.js#webhooksonerror

The handler is called with an error object that has a .event property which has all the information on the event: {id, name, payload}.

You can already access the payload there currently

GitHub

GitHub - octokit/webhooks.js: GitHub webhook events toolset for Node.js

GitHub webhook events toolset for Node.js. Contribute to octokit/webhooks.js development by creating an account on GitHub.

[trammel]

https://github.com/octokit/webhooks.js#webhooksonerror

The handler is called with an error object that has a .event property which has all the information on the event: {id, name, payload}.

You can already access the payload there currently

Oh thank you. I missed that in the documentation.

GitHub

GitHub - octokit/webhooks.js: GitHub webhook events toolset for Node.js

GitHub webhook events toolset for Node.js. Contribute to octokit/webhooks.js development by creating an account on GitHub.