fix: remove update-notifier #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
gr2m
approved these changes
Jun 30, 2022
I'll edit the commit message then |
it's better to catch outdated dependencies before deployment, with tools such as dependabot, instead of only finding about it when you're about to run the application the motivation for having update-notifier isn't strong as per probot#1102 (comment) and it pulls in needless dependencies as showcased in probot#1703, therefore it's better to remove it
joao-paulo-parity
force-pushed
the
update-notifier
branch
from
8866eaa
to
2d53d64
Compare
|
Thanks for your contribution to probot! 🎉 |
|
🎉 This PR is included in version 12.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to catch outdated dependencies before deployment, with tools such as dependabot, instead of only finding about it when you're about to run the application.
The motivation for having update-notifier isn't strong as per #1102 (comment) and it pulls in needless dependencies as showcased in #1703, therefore it's better to remove it.
close #1703