Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wrong log call in onError method #1681

Merged
merged 1 commit into from Apr 26, 2022
Merged

docs: wrong log call in onError method #1681

merged 1 commit into from Apr 26, 2022

Conversation

ademidoff
Copy link
Contributor

@ademidoff ademidoff commented Apr 24, 2022

context.log.error(error) wouldn't work here since context is not exposed


View rendered README.md

`context.log.error(error)` wouldn't work here since context is not exposed
@ademidoff ademidoff requested a review from a team as a code owner April 24, 2022 04:14
@welcome
Copy link

welcome bot commented Apr 24, 2022

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@gr2m gr2m changed the title doc: wrong log call in onError method docs: wrong log call in onError method Apr 26, 2022
@gr2m gr2m merged commit 12d9b05 into probot:master Apr 26, 2022
@welcome
Copy link

welcome bot commented Apr 26, 2022

Thanks for your contribution to probot! 🎉
Congrats!

@github-actions
Copy link

🎉 This PR is included in version 12.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants