Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replaced hbs with express-handlebars #1659

Merged
merged 2 commits into from Mar 8, 2022

Conversation

aasiddiq
Copy link
Contributor

@aasiddiq aasiddiq commented Mar 3, 2022

Fixes #1599

Replacing the package hbs with express-handlebars to fix the vulnerability discovered and reported in https://securitylab.github.com/advisories/GHSL-2021-020-pillarjs-hbs/

The vulnerability was reported to hbs but the issue not addressed and deleted. There are no changes in functionality by replacing the package.

@aasiddiq aasiddiq requested a review from a team as a code owner March 3, 2022 08:42
@welcome
Copy link

welcome bot commented Mar 3, 2022

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@gr2m gr2m merged commit 420f886 into probot:master Mar 8, 2022
@welcome
Copy link

welcome bot commented Mar 8, 2022

Thanks for your contribution to probot! 🎉
Congrats!

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

🎉 This PR is included in version 12.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aasiddiq aasiddiq deleted the users/aasiddiq/fix-hbs-vulnerability branch May 11, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability issue reported in hbs package
2 participants