Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix 404 links for classes and rel links #1649

Merged
merged 4 commits into from Feb 17, 2022
Merged

docs: fix 404 links for classes and rel links #1649

merged 4 commits into from Feb 17, 2022

Conversation

Cybermite
Copy link
Contributor

@Cybermite Cybermite commented Feb 12, 2022

This is to fix various 404 links for classes (modules) and relative doc links.

I didn't look through all the links to see if there are anymore, but these we the main two common issues.


View rendered docs/best-practices.md
View rendered docs/configuration.md
View rendered docs/deployment.md
View rendered docs/development.md
View rendered docs/github-api.md
View rendered docs/hello-world.md
View rendered docs/http.md

@Cybermite Cybermite requested a review from a team as a code owner February 12, 2022 01:53
@welcome
Copy link

welcome bot commented Feb 12, 2022

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

docs/best-practices.md Outdated Show resolved Hide resolved
@AaronDewes
Copy link
Member

Looks good to me (I pushed a minor fixup, I hope that's okay for you @Cybermite).

@gr2m Does this look okay to you? If so, please merge it (I have merge permission, but don't want to merge anything without your approval)

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you both!

@gr2m
Copy link
Contributor

gr2m commented Feb 17, 2022

@AaronDewes no need to wait for me for doc-only fixes like these. We trust you

@gr2m gr2m merged commit c34f64d into probot:master Feb 17, 2022
@welcome
Copy link

welcome bot commented Feb 17, 2022

Thanks for your contribution to probot! 🎉
Congrats!

@Cybermite Cybermite deleted the docs-link-fix branch March 3, 2022 21:07
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

🎉 This PR is included in version 12.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants