-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update @octokit/webhooks
to v9
#1559
Conversation
BREAKING CHANGE: remove '*' event BREAKING CHANGE: app.webhooks.middleware has been removed in `@octokit/webhooks` v9
This also makes it comply with the types expected from the `receive()` function from `@octokit/webhooks`
…foreEach()` in the webhooks test
BREAKING CHANGE: removes the `webhookPath` option on `new Probot({})` for the webhooks middleware
…iddleware.test.ts`
…ally a breaking change, if the `x-hub-signature-256` header is not present, the `webhooks.onError()` callback is not called, because it does not even get that far. But I do not think that it is worth mentioning
…les`, add direct dependency to `@octokit/webhooks-types`
… to represent" error
WebhookExamples.filter( | ||
(event) => event.name === "pull_request" | ||
)[0] as WebhookDefinition<"pull_request"> | ||
).examples[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are unrelated style changes
The TypeScript errors when building are gone via 1d49aa1, do you see any problems in the changes? @wolfy1339 I tested it locally and IntelliSense seems to be working as expected The errors are now signature mismatch errors |
The signature mismatch errors should be gone with the new update of |
All seems good for that change. |
I found some usages of the diff --git a/test/run.test.ts b/test/run.test.ts
index 941ac54..6610278 100644
--- a/test/run.test.ts
+++ b/test/run.test.ts
@@ -80,10 +80,11 @@ describe("run", () => {
});
describe("webhooks", () => {
+ const pushEvent = require("./fixtures/webhook/push.json");
it("POST /", async () => {
server = await run(() => {}, { env });
- const dataString = require("./fixtures/webhook/push.json");
+ const dataString = JSON.stringify(pushEvent);
await request(server.expressApp)
.post("/")
@@ -105,7 +106,7 @@ describe("run", () => {
},
});
- const dataString = require("./fixtures/webhook/push.json");
+ const dataString = JSON.stringify(pushEvent);
await request(server.expressApp)
.post("/custom-webhook") |
This is ready to go now from my side @wolfy1339.
|
This comment has been minimized.
This comment has been minimized.
LGTM 👍 |
🎉 This PR is included in version 12.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: remove '*' event BREAKING CHANGE: app.webhooks.middleware has been removed in `@octokit/webhooks` v9 BREAKING CHANGE: removes the `webhookPath` option on `new Probot({})` for the webhooks middleware Co-authored-by: wolfy1339 <webmaster@wolfy1339.com>
follow up to #1481