Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): support custom message key #1546

Merged
merged 8 commits into from
Jun 1, 2021
Merged

feat(logger): support custom message key #1546

merged 8 commits into from
Jun 1, 2021

Conversation

JacopoDaeli
Copy link
Contributor

@JacopoDaeli JacopoDaeli commented Jun 1, 2021 •
edited by gr2m

fixes #1541

@JacopoDaeli JacopoDaeli requested a review from a team as a code owner June 1, 2021 17:15
@request-info
Copy link

request-info bot commented Jun 1, 2021

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

This was referenced Jun 1, 2021
Closed
Closed
gr2m
gr2m reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the documentation in docs/configuration.md as well?

@JacopoDaeli
Copy link
Contributor Author

@gr2m also would be really great if can also integrate the fix here into this PR. To do so, I need you to create a fix version of the @probot/pino module.

@JacopoDaeli
Copy link
Contributor Author

@gr2m docs added.

gr2m
gr2m reviewed Jun 1, 2021
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
gr2m
gr2m reviewed Jun 1, 2021
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
@JacopoDaeli @gr2m
Update docs/configuration.md
f60bfb4 
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
gr2m
gr2m requested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test so we don't accidentally break that feature in future

@JacopoDaeli
Copy link
Contributor Author

@gr2m I added a test. Can't guarantee is the best way to test this, but it definitely works and does the job.

@JacopoDaeli
Copy link
Contributor Author

I tried to intercept stdout directly but it does't work because of the SonicBoom wrapper pino logger uses.

gr2m
gr2m approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@gr2m gr2m enabled auto-merge (squash) June 1, 2021 20:21
@gr2m gr2m merged commit 01c2006 into probot:master Jun 1, 2021
@welcome
Copy link

welcome bot commented Jun 1, 2021

Thanks for your contribution to probot! 🎉
Congrats!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

🎉 This PR is included in version 11.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JacopoDaeli
Copy link
Contributor Author

@gr2m can we ensure we publish a fix version for this: probot/pino@1bca0bb and that we update the dependency in probot after that?

@snyk-bot snyk-bot mentioned this pull request Jul 3, 2022
Closed
This was referenced Jul 9, 2022
Open
Open
@johnperez416 johnperez416 mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom logger's message key
2 participants
@JacopoDaeli @gr2m