Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Deployments page #1478

Merged
merged 2 commits into from Feb 18, 2021
Merged

Updating the Deployments page #1478

merged 2 commits into from Feb 18, 2021

Conversation

imwiss
Copy link
Contributor

@imwiss imwiss commented Feb 18, 2021

The Serverless section had a broken link since the specific Serverless page was removed here. Furthermore, it feels redundant to keep this section now that we have a section about Serverless Functions in this Deployment page.


View rendered docs/deployment.md

The _serverless_ section had a broken link since the specific _serverless_ page was removed [here](probot@c612fc9). Furthermore, it feels redundant to keep this section now that we have a section about _serverless functions_ in this _deployment_ page.
@imwiss imwiss requested a review from a team as a code owner February 18, 2021 21:19
@welcome
Copy link

welcome bot commented Feb 18, 2021

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I just missed to remove it

@gr2m gr2m merged commit 2c97c99 into probot:master Feb 18, 2021
@welcome
Copy link

welcome bot commented Feb 18, 2021

Thanks for your contribution to probot! 🎉
Congrats!

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants