New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update for serverless/function milestone and new v11 APIs #1467
Conversation
Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details? |
Add short deployment instructions for Vercel, Begin, Cloudflare Functions, GItHub Actions, Azure, Lambda. Reference the example apps for more details -->Lines 125 to 129 in 1a170da
This comment was generated by todo based on a
|
If you need help for the AWS let me know. Maybe I can help with that :) |
Thanks @oscard0m! I'm still confused about what the simplest way is to deploy a function with dependencies to Lambda 🤷🏼 I guess everyone is using serverless to do it? Anything else? |
My experience is with serverless, yep. |
I've installed In the "Test your service" section it says
But there is no URL in my output:
How do I find out the URL of my deployed app?
|
Ah I got it, nevermind my comment above, I had to add
|
@oscard0m I've created a repository and have a work-in-progress pull request for the initial implementation: I've created the app (https://github.com/apps/probot-aws-lambda-example) and installed it on https://github.com/gr2m/sandbox. No errors are thrown, but no comment is posted either. I think the Probot function defined in
|
I suspect the only step missing is to replace your Trying to reproduce all the ecosystem examples you created:
|
no I set that URL correctly. I see the correct response to GitHub's webhook requests in the app registration's "Avanced" tab on GitHub
sounds like the Webhook Secret is not configured correctly. I configured three parameters in the Serverless dashboard, that I reference in Did you set these up? |
I was missing that part of the parameters. Now is running but no logs as it is happening to you. Checking Cloudwatch the Lambda is executed but no logs. Keep looking into it |
Did not have time to find the root of the issue. I have to go to 🛌🏽. enabled Adding some loggers on the way seems like the verification step is completed successfully but the receiver is not triggered. I will try to get some more time debugging it. Any idea on what it could be happening? Maybe a Promise not awaited makes the lambda die before? (In my company we are using a super old version of |
I have an app working here. I think you were just missing the parsing of the body. |
Thanks @helaili, that made no difference. If you have the raw string available I would recommend to pass that to I also set |
Oh wait, it did work, I just don't understand why lol |
I think you are right, I have to pass payload as object to |
Thanks @helaili 🙌🏾 |
Did anyone of you successfully deploy a serverless app via GitHub Actions using a serverless access key? I tried using https://github.com/marketplace/actions/serverless but I'm getting
Although the I was able to run it locally successfully
I also tried to checkout the PR into a new a fresh directory so that the |
okay I think I understand why it's working locally. I had the |
after removing the
But running the same on Actions gives me
Gosh I've spent the whole day on this :( |
We don't use Github Actions for serverless deployment in my company so no experience with it. |
Hallelujah the problem went away when I went back to use the |
What changed from first try? Congrats 🎉🎊🎈🍾 |
The docs of the action suggest that you either set |
docs/deployment.md
Outdated
@@ -10,7 +10,7 @@ Every app can either be deployed stand-alone, or combined with other apps in one | |||
|
|||
**Contents:** | |||
|
|||
1. [Create the GitHub App](#create-the-github-app) | |||
1. [Register the GitHub App](#register-the-github-app) | |||
1. [Deploy the app](#deploy-the-app) | |||
1. [Glitch](#glitch) | |||
1. [Heroku](#heroku) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a link to Serverless here, too.
The race is on lol: probot/sandbox#8 |
Same code for three of them? Also, lambas in same state (hot or asleep) @gr2m |
Yes, all use the same Probot app function /**
* @param {import('probot').Probot} app
*/
module.exports = (app) => {
app.log("Yay! The app was loaded!");
app.on("issues.opened", async (context) => {
return context.octokit.issues.createComment(
context.issue({ body: "Hello, World!" })
);
});
};
It's not a scientific test 🤷🏼 just a fun observation. I guess we could create a new issue on a schedule and then another issue a few seconds later and then compare the times over time, but it's not a competition. There are other projects that probably do better at comparing the different providers |
We now have 6 example apps for
and adapters for
(the other 3 work with Probot's built-in I'll update the docs, then we should be good for a more public launch to get Probot's serverless/function capabilities some traction |
The new types introduced in `@octokit/webhooks@7.22.0`, are incompatible with the current codebase. This will prevent users from getting anything newer than the pinned version in order to avoid type errors for end-users
Docs are not as great as they could be, but it's a start. Contributions are very, very welcome! |
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TODOS
@actions/core
for logging adapter-github-actions#19View rendered docs/configuration.md
View rendered docs/deployment.md
View rendered docs/development.md
View rendered docs/extensions.md
View rendered docs/github-api.md
View rendered docs/hello-world.md
View rendered docs/http.md
View rendered docs/logging.md
View rendered docs/pagination.md
View rendered docs/serverless-deployment.md
View rendered docs/testing.md
View rendered docs/webhooks.md